Allow specifying differential class in frame init#6317
Merged
adrn merged 3 commits intoastropy:masterfrom Jul 5, 2017
Merged
Conversation
mhvk
approved these changes
Jul 4, 2017
Contributor
mhvk
left a comment
There was a problem hiding this comment.
(from holidays, no brief) I had removed this more or less on purpose, with the logic was that you should never be able to set a differential class inconsistent with a base class anyway, so that, e.g., sphericalcoslat would just set the differential class and representation. but I do see that this makes unitspherical impossible, and this seems a reasonable solution. Still not 100% sure it is necessary to have this short-cut to passing a dict to representation, but only -0, so since you both feel it is worth it, OK to proceed.
Member
Author
|
Approved and passing - hitting merge! |
bsipocz
pushed a commit
that referenced
this pull request
Jul 5, 2017
Allow specifying differential class in frame init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6314
This adds support for specifying a differential class in the frame intializers, which should mirror the way passing in a representation class works. This supports, e.g.:
(also
differential_cls={'s': coord.CartesianDifferential})This also decouples setting the representation class from setting the differential class, so this is now valid as long as the differential class is compatible with the representation: