Remove deprecated sigma_clip keywords#5715
Merged
crawfordsm merged 3 commits intoastropy:masterfrom Jan 19, 2017
Merged
Conversation
dmopalmer
pushed a commit
to dmopalmer/astropy
that referenced
this pull request
Jan 23, 2017
Remove deprecated sigma_clip keywords SkyCoord.position_angle bug fix Fix for bug in astropy#5702. Also affects astropy#5722, astropy#3106. Attempting to commit changes for coord_offset before trying to merge changes from posang_fix position_offset before merging in cache_frame_attrs Revert "position_offset before merging in cache_frame_attrs" This reverts commit 9ef159218b746720a3d2134b5449bfb2f1a68f4f. `SkyCoord.offset_by()` and `.directional_offset_to()` functions. Simplistic treatment of coordinate offsets. Definition of position_angle at poles must be refined. Change in FIXME comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sigandvarfunckeywords were deprecated in the astropy 1.1 release. This PR removes them for the 2.0 release.EDIT: this PR also removes an unused loop counter