Make astrometric frames be on [-180, 180] and change their name to SkyOffsetFrame#5023
Make astrometric frames be on [-180, 180] and change their name to SkyOffsetFrame#5023eteq merged 2 commits intoastropy:masterfrom
Conversation
|
👍 on the concept (both name change and wrapping). Obviously the widespread test fail needs fixing. |
|
Oh, fascinating: the test failures are not due to this change itself: they're due to the problem that should be fixed by #5021. That bug turns out to be order-dependent in that if the tests that use I just checked now, and if I run the full testing suite on this merged with master I get the error, but if both this and #5021 are merged in, the error goes away. So probably the best thing is to merge #5021, then I can rebase this on that to make sure all the tests pass, and then this can be merged. |
|
Sometimes "fascinating" is just not what you want in life. |
|
rebased on #5021. Hopefully the test will now pass (they did for me locally in various circumstances, anyway). |
|
👍 |
|
OK, this looks good now, so I'm going to merge and backport to 1.2 . |
Make astrometric frames be on [-180, 180] and change their name to SkyOffsetFrame
|
backported to v1.2.x in b7b93b4 |
This closes #5002 by implementing the two changes discussed there: astrometric frames now have longitudes that wrap at 180 (i.e. they are on [-180, 180] degrees), and they have been renamed SkyOffsetFrame, due to the ambiguity of the name.
cc @alexrudy @Kevtron @astrofrog @mcara
I've marked it for 1.2 because it's clearly a significant change to a feature that's new there (Assuming you agree, @astrofrog and @taldcroft?)
Note that this needs to be backported after #4992, as there would otherwise be a ton of conflicts.