Modified MatrixRotation2D model such that angle increases counterclockwise#2266
Closed
larrybradley wants to merge 3 commits into
Closed
Modified MatrixRotation2D model such that angle increases counterclockwise#2266larrybradley wants to merge 3 commits into
larrybradley wants to merge 3 commits into
Conversation
Member
|
Maybe rather than merge this as is, this PR would be a good place to go ahead and break |
Contributor
|
@embray Don't we need models working properly with array parameters for this? |
Member
|
Ultimately yes, but no more so than it's technically needed for |
embray
added a commit
to embray/astropy
that referenced
this pull request
Apr 2, 2014
…the sense or rotatioin is in fact counter-clockwise
Merged
Member
|
This should be closed in favour of #2269, no? |
ktchrn
pushed a commit
to ktchrn/astropy
that referenced
this pull request
Oct 28, 2014
…the sense or rotatioin is in fact counter-clockwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #2199. The
test_Gaussian2DRotation()test will fail until #2199 is merged.