Skip to content

TST: stop building wheels against dev build deps in CI#19429

Merged
neutrinoceros merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/drop-cython-dev-builds
Mar 16, 2026
Merged

TST: stop building wheels against dev build deps in CI#19429
neutrinoceros merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/drop-cython-dev-builds

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented Mar 16, 2026

Description

This is basically the same as #19426, only taken to its logical conclusion by also removing the cruft that stops being useful.
close #19426
close #19422

for context, this scheme was implemented in #15524 in order to improve testing of numpy 2.0 as it was being developed. I don't think we need it anymore.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.1 milestone Mar 16, 2026
@neutrinoceros neutrinoceros added no-changelog-entry-needed Build all wheels Run all the wheel builds rather than just a selection backport-v7.2.x on-merge: backport to v7.2.x labels Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros force-pushed the tst/drop-cython-dev-builds branch from d927844 to c45319d Compare March 16, 2026 10:10
@neutrinoceros neutrinoceros marked this pull request as ready for review March 16, 2026 10:10
Copy link
Copy Markdown
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@neutrinoceros neutrinoceros merged commit d72b81e into astropy:main Mar 16, 2026
41 of 43 checks passed
@neutrinoceros neutrinoceros deleted the tst/drop-cython-dev-builds branch March 16, 2026 12:16
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 16, 2026
@pllim
Copy link
Copy Markdown
Member

pllim commented Mar 16, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v7.2.x on-merge: backport to v7.2.x Build all wheels Run all the wheel builds rather than just a selection no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: wheel builds are failing on Linux

3 participants