Skip to content

DEP: bump minimal (optional) requirement on asdf-astropy (0.3.0 -> 0.7.0)#19002

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:dep/bump-asdf-astropy_0.7
Nov 28, 2025
Merged

DEP: bump minimal (optional) requirement on asdf-astropy (0.3.0 -> 0.7.0)#19002
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:dep/bump-asdf-astropy_0.7

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

Fixes #18992 (precariously)
see #18992 (comment) for the complete rationale
in short: as much as I'd like to avoid going for user-visible (and in this instance, fragile) solutions to the overarching issue #18782, I haven't been able to find anything better yet, so let's see what others think about this last resort.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone Nov 27, 2025
@neutrinoceros neutrinoceros added no-changelog-entry-needed dependencies Pull requests that update a dependency file labels Nov 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but let's wait a few days just in case @braingram or @WilliamJamieson have objection.

@pllim pllim merged commit af79041 into astropy:main Nov 28, 2025
41 checks passed
@neutrinoceros neutrinoceros deleted the dep/bump-asdf-astropy_0.7 branch November 28, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file installation no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST/DEP: circular dependency with astropy-asdf makes lowest graph resolution unworkable

3 participants