Skip to content

BUG: fix forward compatibility with numpy 2.4 (dev) in np.array2string helper function and tests#18885

Merged
mhvk merged 1 commit intoastropy:mainfrom
neutrinoceros:unit/compat-numpy-2.4
Nov 11, 2025
Merged

BUG: fix forward compatibility with numpy 2.4 (dev) in np.array2string helper function and tests#18885
mhvk merged 1 commit intoastropy:mainfrom
neutrinoceros:unit/compat-numpy-2.4

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

follow up to #18821
xref: numpy/numpy#30139

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.0 milestone Nov 11, 2025
@github-actions github-actions bot added the units label Nov 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review November 11, 2025 21:03
@neutrinoceros neutrinoceros requested a review from mhvk November 11, 2025 21:03
Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy how that made life easier for us! (and good that your signature checking found the problem - this is an improvement for numpy too!)

@mhvk mhvk enabled auto-merge November 11, 2025 21:25
@mhvk mhvk merged commit 528c5f4 into astropy:main Nov 11, 2025
51 of 53 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Nov 11, 2025
…2.4 (dev) in `np.array2string` helper function and tests
@neutrinoceros neutrinoceros deleted the unit/compat-numpy-2.4 branch November 11, 2025 21:56
pllim added a commit that referenced this pull request Nov 11, 2025
…885-on-v7.2.x

Backport PR #18885 on branch v7.2.x (BUG: fix forward compatibility with numpy 2.4 (dev) in `np.array2string` helper function and tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants