Skip to content

TST: ban a known incompatible pre-release version of pyparsing in devdeps testing#18651

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/tmp/prevent-pyparsing-mpl-incompat
Sep 30, 2025
Merged

TST: ban a known incompatible pre-release version of pyparsing in devdeps testing#18651
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/tmp/prevent-pyparsing-mpl-incompat

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

example logs
The issue is already known upstream, and will likely be addressed with the next release of matplotlib
xref: matplotlib/matplotlib#30617

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.1.1 milestone Sep 30, 2025
@neutrinoceros neutrinoceros added testing Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Sep 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review September 30, 2025 09:53
@neutrinoceros neutrinoceros added the Extra CI Run cron CI as part of PR label Sep 30, 2025
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Whoops, didn't get all affected tox factors. Will push again shortly.

@neutrinoceros neutrinoceros force-pushed the tst/tmp/prevent-pyparsing-mpl-incompat branch from e6de6c7 to ee11043 Compare September 30, 2025 12:00
@neutrinoceros neutrinoceros force-pushed the tst/tmp/prevent-pyparsing-mpl-incompat branch from ee11043 to 0e9e1da Compare September 30, 2025 12:07
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

FYI @Cadair, this is the kind of thing that gets much easier to handle smoothly when uv is used in all tox environments :)

@pllim
Copy link
Copy Markdown
Member

pllim commented Sep 30, 2025

If matplotlib is fixing this fast enough, maybe we can just wait it out.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

This patch has 0 impact on users, so I'd still prefer to go with it now. It could be days/weeks before matplotlib cuts a new release

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is follow up issue to revert, so okay, let's get this in for now. Thanks!

@pllim pllim merged commit e92043e into astropy:main Sep 30, 2025
36 of 37 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 30, 2025
@neutrinoceros neutrinoceros deleted the tst/tmp/prevent-pyparsing-mpl-incompat branch September 30, 2025 13:47
pllim added a commit that referenced this pull request Sep 30, 2025
…651-on-v7.1.x

Backport PR #18651 on branch v7.1.x (TST: ban a known incompatible pre-release version of pyparsing in devdeps testing)
@neutrinoceros neutrinoceros mentioned this pull request Oct 9, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants