Fix LZMA invalid file checking in utils#17984
Merged
mhvk merged 2 commits intoastropy:mainfrom Apr 9, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
kYwzor
added a commit
to kYwzor/astropy
that referenced
this pull request
Apr 8, 2025
Member
Author
|
Huh, pretty sure the failed checks are unrelated. Every test was passing (except Check PR milestone / milestone_checker) before I added the towncrier file and there's no way that's the source of these failures. What's the best way to trigger CI again? |
utils
Member
Member
Author
|
I've done a rebase and almost everything is passing now... but three checks failed because they couldn't checkout(???). |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
All in the green now thanks @pllim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address an incorrect check for invalid LZMA files. Fixes #17983.
The incorrect check is caused by a combination of factors:
test_local_data_obj_invalidtest looks like it's testing for the ".xz" case, it actually isn't. This is because theinvalid.dat.xzfile wasn't being created by thebad_compressedfunction, so the ".xz" was never actually triggered.