Skip to content

TST: Replace test with conf in test_find_mod_objs()#17873

Merged
mhvk merged 1 commit into
astropy:mainfrom
pllim:tst-introspection-update
Mar 11, 2025
Merged

TST: Replace test with conf in test_find_mod_objs()#17873
mhvk merged 1 commit into
astropy:mainfrom
pllim:tst-introspection-update

Conversation

@pllim

@pllim pllim commented Mar 11, 2025

Copy link
Copy Markdown
Member

Description

This pull request is to apply diff to astropy/utils/tests/test_introspection.py from #16208 and also apply comment from https://github.com/astropy/astropy/pull/16208/files#r1745565811 . This is a precursor for #16177 so it is one less thing we worry about when we deprecate the test runner. Should be uncontroversial but backport is also probably unnecessary.

  • Add Mridul and Marten as co-authors.
  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

This comment was marked as outdated.

Co-authored-by: Mridul Seth <mail@mriduls.com>
Co-authored-by: Marten van Kerkwijk <mhvk@astro.utoronto.ca>
@pllim pllim force-pushed the tst-introspection-update branch from 8380392 to a02d0f4 Compare March 11, 2025 19:38
@pllim pllim marked this pull request as ready for review March 11, 2025 19:54
@pllim pllim requested a review from mhvk March 11, 2025 19:54

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is indeed uncontroversial!

@mhvk mhvk merged commit f3e1013 into astropy:main Mar 11, 2025
@pllim pllim deleted the tst-introspection-update branch March 11, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants