Fixed missed inline import for subprocess.Popen#1785
Merged
embray merged 1 commit intoastropy:masterfrom Nov 14, 2013
Merged
Conversation
Member
Member
|
(but the RC has already been tagged, so we shouldn't delay that, let's just backport this to 0.3.x once the branch is created, then include it in the final version) |
Member
|
I agree with @astrofrog this should go into 0.3.0 - @embray, do you want to merge this yourself so you can backport it, or can we just merge it and you'll run the script before the final release? |
Member
|
Oops. This may well be my fault in fact. Yes, it's because of this sort of thing that we make release candidates :) (This might be a good place to mention that the 0.3 release candidate is out and people should download it and use it: https://testpypi.python.org/pypi/astropy/0.3rc1) |
embray
added a commit
that referenced
this pull request
Nov 14, 2013
Fixed missed inline import for subprocess.Popen
embray
added a commit
that referenced
this pull request
Nov 14, 2013
Fixed missed inline import for subprocess.Popen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The little bug was triggered by this build of astroquery: https://travis-ci.org/astropy/astroquery/jobs/13965996