Skip to content

TST: use earlier ubuntu to see if that allows docker images to work#17807

Merged
pllim merged 1 commit intoastropy:mainfrom
mhvk:try-fix-other-arch
Feb 24, 2025
Merged

TST: use earlier ubuntu to see if that allows docker images to work#17807
pllim merged 1 commit intoastropy:mainfrom
mhvk:try-fix-other-arch

Conversation

@mhvk
Copy link
Copy Markdown
Contributor

@mhvk mhvk commented Feb 22, 2025

Using ubuntu-22.04 as base worked for me in baseband to get the exotic architecture tests working again, so I thought I might give it a try for astropy too.

@mhvk mhvk added this to the v7.0.2 milestone Feb 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk
Copy link
Copy Markdown
Contributor Author

mhvk commented Feb 23, 2025

@pllim, @neutrinoceros - going back to ubuntu-22.04 on the host seems to have solve the exotic arch problems, perhaps because it has an older qemu or so (the various issues confused me).

Anyway, I think perhaps we should just go with this for now...

Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Following the confused conversations upstream, it looked to me that this wouldn't be a silver bullet, so I didn't try, but if it works, I agree it's the right thing to do for now.

Should also close #17664 (that issue should probably be re-titled though).

# of using system libraries and using pytest directly.

runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should leave an inline comment there as well to link to upstream issues like

@pllim
Copy link
Copy Markdown
Member

pllim commented Feb 23, 2025

Sometimes the best solution is the simplest. Thanks!

In applying backport label, the tests rerunning. Sorry about that. I can check tomorrow at work tomorrow and merge if they still pass, unless someone beats me to it.

@pllim pllim merged commit 3ad5727 into astropy:main Feb 24, 2025
46 of 48 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 24, 2025
@mhvk mhvk deleted the try-fix-other-arch branch February 24, 2025 15:54
neutrinoceros added a commit that referenced this pull request Feb 24, 2025
…807-on-v7.0.x

Backport PR #17807 on branch v7.0.x (TST: use earlier ubuntu to see if that allows docker images to work)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: s390x fails with pyerfa pyproject.toml does not contain a tool.setuptools_scm section TST: ppc64le fails with run-on-arch-install.sh error

3 participants