-
-
Notifications
You must be signed in to change notification settings - Fork 2k
MNT: upgrade sp-repo-review (v2024.08.19 -> v2025.01.22)
#17723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: upgrade sp-repo-review (v2024.08.19 -> v2025.01.22)
#17723
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
v2024.08.19 -> v2025.01.22)
|
Yes for now, but can you put this in |
|
Did you intend to post this reply somewhere else or am I missing something ? This is not about ruff (I think ?). |
|
You're right. I was thinking about our temporary ignores. Because there's slow discussion about not packaging the tests inside of astropy, per recommendation by Scientific Python |
|
Should I link an issue or PR in particular in a comment ? |
|
Nah. G2G. |
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncontroversial enough. Thanks!
Description
Close #17719