Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

Description

Close #17719

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros changed the title MNT: upgrade sp-repo-review (v2024.08.19 -> v2025.01.22) MNT: upgrade sp-repo-review (v2024.08.19 -> v2025.01.22) Feb 4, 2025
@nstarman
Copy link
Member

nstarman commented Feb 4, 2025

Yes for now, but can you put this in ruff.toml instead?

@neutrinoceros
Copy link
Contributor Author

Did you intend to post this reply somewhere else or am I missing something ? This is not about ruff (I think ?).

@nstarman
Copy link
Member

nstarman commented Feb 4, 2025

You're right. I was thinking about our temporary ignores. Because there's slow discussion about not packaging the tests inside of astropy, per recommendation by Scientific Python

@neutrinoceros
Copy link
Contributor Author

Should I link an issue or PR in particular in a comment ?

@nstarman
Copy link
Member

nstarman commented Feb 4, 2025

Nah. G2G.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial enough. Thanks!

@pllim pllim merged commit f1b3fdc into astropy:main Feb 4, 2025
29 of 31 checks passed
@neutrinoceros neutrinoceros deleted the mnt/upgrade_sp-repo-review_2025.01.22 branch February 4, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNT: upgrading sp-repo-review pre-commit hook

3 participants