Skip to content

MNT: upgrading sp-repo-review pre-commit hook #17719

@neutrinoceros

Description

@neutrinoceros

The following automatic upgrade was attempted in #17710

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 659235ef2a..ebffadb149 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -71,7 +71,7 @@ repos:
       - id: ruff-format
 
   - repo: https://github.com/scientific-python/cookie
-    rev: 2024.08.19
+    rev: 2025.01.22
     hooks:
       - id: sp-repo-review

But it breaks for astropy because of a new rule requiring a root tests/ folder.

I think the toothpaste is long out of the tube, and we can't reasonably be expected to change the repo's layout just to satisfy this rule, so skipping it would be the natural solution. However, quoting from https://github.com/scientific-python/cookie:

a way to specify ignored checks will likely be added eventually

So something needs to happen upstream for this hook to be upgradable again. I'll report there and link back.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions