Skip to content

TST: Pin bs4 in oldestdeps#17711

Merged
pllim merged 1 commit intoastropy:mainfrom
pllim:fix-oldest-deps
Feb 3, 2025
Merged

TST: Pin bs4 in oldestdeps#17711
pllim merged 1 commit intoastropy:mainfrom
pllim:fix-oldest-deps

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Feb 3, 2025

Description

This pull request is to address failure in oldestdeps job when bs4 was bumped from 4.12.3 to 4.13.1. This patch pins bs4 in oldestdeps to the minversion declared in pyproject.toml.

This can be merged way sooner than #16963 though that PR would provide a more permanent solution if it goes forward.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim marked this pull request as ready for review February 3, 2025 18:55
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Feb 3, 2025

Merging now to unblock CI.

@pllim pllim merged commit f6bcea3 into astropy:main Feb 3, 2025
24 checks passed
@pllim pllim deleted the fix-oldest-deps branch February 3, 2025 18:56
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 3, 2025
pllim added a commit that referenced this pull request Feb 3, 2025
…711-on-v7.0.x

Backport PR #17711 on branch v7.0.x (TST: Pin bs4 in oldestdeps)
@neutrinoceros
Copy link
Copy Markdown
Contributor

This can be merged way sooner than #16963

🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants