MNT: Run PTH flake test in prep for supporting pathlib (modeling)#16940
MNT: Run PTH flake test in prep for supporting pathlib (modeling)#16940pllim merged 1 commit intoastropy:mainfrom
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
fdeba73 to
842ef81
Compare
|
Does this supersede #16927 ? |
|
Oh, good catch, I missed that these were targeting the same sub-package ! |
There was a problem hiding this comment.
Can f.write be replaced with write_text?
842ef81 to
12cfb5e
Compare
pllim
left a comment
There was a problem hiding this comment.
Diff looks fine. Since this is generic path handling not related to actual fitting algorithm, I think I am comfortable enough to approve myself. Let's wait for the CI though.
Thanks!
|
Hmm. I see this error but it is from #16939 ? |
3cf8c4c to
864a55b
Compare
|
@neutrinoceros - could you rebase? |
864a55b to
a8e6f9c
Compare
|
@astrofrog done ! |
|
Thanks! |
Description
Ref #16924
This is in the continuation of #16060