Skip to content

MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16928)#16927

Closed
neutrinoceros wants to merge 2 commits intoastropy:mainfrom
neutrinoceros:modeling/rf/pth_checks
Closed

MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16928)#16927
neutrinoceros wants to merge 2 commits intoastropy:mainfrom
neutrinoceros:modeling/rf/pth_checks

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Sep 3, 2024

Description

Extracted from #16060

Blocked by

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
Copy link
Contributor Author

Looks like I just do astropy/utils first for this one to work

Co-authored-by: Mridul Seth <git@mriduls.com>
Co-authored-by: Mridul Seth <git@mriduls.com>
@neutrinoceros neutrinoceros changed the title MNT: Run PTH flake test in prep for supporting pathlib (modeling) MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16928) Sep 3, 2024
@neutrinoceros neutrinoceros changed the title MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16928) MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16940 and #16928) Sep 6, 2024
@neutrinoceros neutrinoceros changed the title MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16940 and #16928) MNT: Run PTH flake test in prep for supporting pathlib (modeling) (⏰ wait for #16928) Oct 16, 2024
@neutrinoceros neutrinoceros modified the milestones: v7.0.0, v7.1.0 Oct 16, 2024
@github-actions github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Feb 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@neutrinoceros
Copy link
Contributor Author

closing following #16928 (comment)

@neutrinoceros neutrinoceros deleted the modeling/rf/pth_checks branch February 6, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants