Skip to content

BUG: Fix test_plt_scatter_masked matplotlib check that broke pyinstaller job#16854

Merged
pllim merged 1 commit intoastropy:mainfrom
pllim:fix-mpl-check
Aug 19, 2024
Merged

BUG: Fix test_plt_scatter_masked matplotlib check that broke pyinstaller job#16854
pllim merged 1 commit intoastropy:mainfrom
pllim:fix-mpl-check

Conversation

@pllim
Copy link
Member

@pllim pllim commented Aug 19, 2024

Description

The check was originally modified in #16820 but that caused other tests to be skipped when they are not supposed to when matplotlib is not installed (can't say I grok why at the time of writing this). So #16843 was done but it caused pyinstaller job to fail with E KeyError: 'matplotlib' during test collection. This PR is an attempt to skip only test_plt_scatter_masked when matplotlib conditions are not satisfied and to not break pyinstaller job doing that.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added testing Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Aug 19, 2024
@pllim pllim added this to the v7.0.0 milestone Aug 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

This comment was marked as outdated.

Sign in to view
@pllim pllim mentioned this pull request Aug 19, 2024
Merged
mhvk
mhvk approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I'm approving, though obviously the real test is in the tests...

@pllim
Copy link
Member Author

pllim commented Aug 19, 2024

Log from minimal deps job:

astropy/utils/masked/tests/test_masked.py . [ 93%]
........................................................................ [ 93%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 95%]
........................................................................ [ 95%]
........................................................................ [ 95%]
...........................s                                             [ 95%]

Log from all deps job:

astropy\utils\masked\tests\test_masked.py . [ 92%]
........................................................................ [ 92%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 94%]
............................                                             [ 94%]

Log from pyinstaller:

astropy_tests/utils/masked/tests/test_masked.py ........................ [ 92%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 95%]
.....                                                                    [ 95%]

@pllim
Copy link
Member Author

pllim commented Aug 19, 2024 •
edited
Loading

Link check failure unrelated. RTD job got stuck and also irrelevant, so I canceled it. Merging. Thanks for the review!

@pllim pllim marked this pull request as ready for review August 19, 2024 20:55
@pllim pllim merged commit 8edcd7b into astropy:main Aug 19, 2024
@pllim pllim deleted the fix-mpl-check branch August 19, 2024 21:32
@mhvk
Copy link
Contributor

mhvk commented Aug 19, 2024

Thanks! Happy to have that one behind us...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes

Assignees

No one assigned

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR no-changelog-entry-needed testing utils.masked

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @mhvk