Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

No worries, it was not at all obvious this would cause the tests to be skipped, rather than given an error!

This appears to crash on daily cron (specifically on pyinstaller)
https://github.com/astropy/astropy/actions/runs/10446362063/job/28923664532

This appears to crash on daily cron (specifically on pyinstaller) https://github.com/astropy/astropy/actions/runs/10446362063/job/28923664532

What? How is this possible. Does it evaluate it even if not HAS_PLT?

Yes I think this condition is evaluated: matplotlib is indeed installed on this job, but somehow minversion just crashes with

importlib/metadata/__init__.py:548: in from_name
    ???
E   importlib.metadata.PackageNotFoundError: No package metadata was found for matplotlib

I never heard of pyinstaller before so I don't know off hand how this is happening but it's oddly specific to that env

It's weird that the previous version in which matplotlib was imported did work. Maybe easiest is just to revert to that...

Argh, sorry to cause so much trouble.

Hopefully #16854 is finally the correct fix? 🤞