TST: bump hash for failing mpldev image test#16722
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
| @@ -1,5 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
{ "astropy.visualization.wcsaxes.tests.test_frame.TestFrame.test_custom_frame": "d79ed179997672de0a929aedee3c2ac590e04b544558808ac9bace8937a60275", "astropy.visualization.wcsaxes.tests.test_frame.TestFrame.test_update_clip_path_rectangular": "30e13643c770a26b2707745143f50a735daa6f37a6a8258e733ae35338a4a1bb", "astropy.visualization.wcsaxes.tests.test_frame.TestFrame.test_update_clip_path_nonrectangular": "37de34740cef2897effc9de5e6726ef3955a3449d0fa6a929350301500557b8e", "astropy.visualization.wcsaxes.tests.test_frame.TestFrame.test_update_clip_path_change_wcs": "c68e961f0a21cc0dcc43c523cee1c564d94bd96c795f976d51e5198fc52f83cc" }
There was a problem hiding this comment.
Sorry I don't get what you're suggesting here
There was a problem hiding this comment.
Update the Baseline Image
Open a terminal on system.
Navigate to the directory containing the test results:
cd /home/circleci/project/results/astropy.visualization.wcsaxes.tests.test_frame.TestFrame.test_custom_frame/
Rerun the tests to verify everything works:
pytest --pyargs astropy
There was a problem hiding this comment.
Ah, I think I see what's confusing here:
Image generation is not 100% platform portable, but at the same time we cannot tolerate any level of difference between reference images and the ones we get from CI. As a consequence, we can't run image tests locally. I think this is why you're seeing differences on your side, but CI is the only authority in this context.
There was a problem hiding this comment.
oh! I think I got it
Consider using a Docker container that mimics the CI environment for local development. This can help reduce discrepancies between local runs and CI, though it may not completely eliminate differences in image generation.
There was a problem hiding this comment.
@astrofrog and @Cadair set this up, so maybe they can comment from the infrastructure side.
| @@ -1,5 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Update the Baseline Image
Open a terminal on system.
Navigate to the directory containing the test results:
cd /home/circleci/project/results/astropy.visualization.wcsaxes.tests.test_frame.TestFrame.test_custom_frame/
Rerun the tests to verify everything works:
pytest --pyargs astropy
|
Hmm why is this not showing on the CI run for |
pllim
left a comment
There was a problem hiding this comment.
OK the rerun failed, but green here, so let's get this in. Thanks!
…722-on-v6.1.x Backport PR #16722 on branch v6.1.x (TST: bump hash for failing mpldev image test)
Description
Fix a failing image comparison test (the hash changed somehow but the image itself didn't, at least not in any human visible way)
example logs