Skip to content

Fix #16246 change log entry#16333

Merged
pllim merged 1 commit intoastropy:mainfrom
eerovaher:fix-coords-changelog
Apr 23, 2024
Merged

Fix #16246 change log entry#16333
pllim merged 1 commit intoastropy:mainfrom
eerovaher:fix-coords-changelog

Conversation

@eerovaher
Copy link
Member

@eerovaher eerovaher commented Apr 23, 2024

Description

The change log entry uses a wrong name for the newly introduced argument it describes. The related Wnat's New entry, docstrings and narrative documentation all use the correct argument name.

xref #16246

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@eerovaher eerovaher added Docs coordinates Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed backport-v6.1.x labels Apr 23, 2024
@eerovaher eerovaher added this to the v6.1.0 milestone Apr 23, 2024
@eerovaher eerovaher requested a review from pllim April 23, 2024 21:01
@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@eerovaher eerovaher changed the title Fix #16246 change log entry [ci skip] Fix #16246 change log entry Apr 23, 2024
@eerovaher eerovaher added skip-changelog-checks Tells bot to skip changlog checks and removed no-changelog-entry-needed labels Apr 23, 2024
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Member

pllim commented Apr 23, 2024

I want to wait for RTD, just in case.

@pllim pllim merged commit 0d4fc36 into astropy:main Apr 23, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 23, 2024
pllim added a commit that referenced this pull request Apr 23, 2024
…333-on-v6.1.x

Backport PR #16333 on branch v6.1.x (Fix #16246 change log entry)
@eerovaher eerovaher deleted the fix-coords-changelog branch April 23, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release coordinates Docs skip-changelog-checks Tells bot to skip changlog checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants