Skip to content

EXP: See what happens with pytest-mpl dev#15942

Closed
pllim wants to merge 1 commit intoastropy:mainfrom
pllim:circleci-pytest-mpl-dev
Closed

EXP: See what happens with pytest-mpl dev#15942
pllim wants to merge 1 commit intoastropy:mainfrom
pllim:circleci-pytest-mpl-dev

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Jan 24, 2024

Description

This pull request is an unofficial companion to #15940 . I just want to see what sort of error/warning to expect using unreleased pytest-mpl + pluggy 1.4.0

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Copy Markdown
Member Author

pllim commented Jan 24, 2024

#15929 (comment) 🤷‍♀️

@pllim pllim closed this Jan 24, 2024
@pllim pllim deleted the circleci-pytest-mpl-dev branch January 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant