Skip to content

TST: pin pluggy in image tests to get by future incompatibility with pytest-mpl#15940

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/workaround_pytest_mpl_pluggy_1.4
Jan 24, 2024
Merged

TST: pin pluggy in image tests to get by future incompatibility with pytest-mpl#15940
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/workaround_pytest_mpl_pluggy_1.4

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented Jan 24, 2024

Description

This is a quick solution to make image tests work again.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Copy Markdown
Member

pllim commented Jan 24, 2024

CircleCI is green again! 👏

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now. Can you please take it out of draft so I can merge? Thanks!

@neutrinoceros neutrinoceros marked this pull request as ready for review January 24, 2024 18:31
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

there you go !

@pllim
Copy link
Copy Markdown
Member

pllim commented Jan 24, 2024

No need to wait for OSX. Seems to be queued a long time.

@pllim pllim merged commit 71061de into astropy:main Jan 24, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jan 24, 2024
@neutrinoceros neutrinoceros deleted the tst/workaround_pytest_mpl_pluggy_1.4 branch January 24, 2024 18:36
pllim added a commit that referenced this pull request Jan 24, 2024
…940-on-v6.0.x

Backport PR #15940 on branch v6.0.x (TST: pin pluggy in image tests to get by future incompatibility with pytest-mpl)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants