Skip to content

Conversation

@pllim
Copy link
Member

@pllim pllim commented Oct 5, 2023

Description

This pull request is to revert #15433 when python/cpython#110371 is finally deployed.

Fixes #15428

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

in intersphinx because they removed a ref label but then readded it.
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Oct 5, 2023
@pllim pllim added this to the v6.0 milestone Oct 5, 2023
@github-actions github-actions bot added the Docs label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim marked this pull request as ready for review October 5, 2023 21:50
@pllim
Copy link
Member Author

pllim commented Oct 5, 2023

Nice, their doc fix is deployed. I'll just merge.

@pllim pllim merged commit 71f22d7 into astropy:main Oct 5, 2023
@pllim pllim deleted the revert-pr-15433 branch October 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Docs no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTD fails with WARNING: undefined label: 'python:bltin-boolean-values'

1 participant