Skip to content

Use Python 3.11 for intersphinx links to avoid 3.12 warnings #15433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pllim merged 1 commit into from
Oct 4, 2023
Merged

Use Python 3.11 for intersphinx links to avoid 3.12 warnings #15433

pllim merged 1 commit into from
Oct 4, 2023

Conversation

@saimn
Copy link
Contributor

@saimn saimn commented Oct 4, 2023 •
edited
Loading

Ref #15428

Description

This pull request is to address ...

Fixes #

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added this to the v6.0 milestone Oct 4, 2023
@saimn saimn changed the title Use Python 3.11 for intersphinx links to avoid 3.12 warnings [skip ci] Use Python 3.11 for intersphinx links to avoid 3.12 warnings Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is cleaner. Thanks!

@pllim pllim merged commit e27b224 into astropy:main Oct 4, 2023
This was referenced Oct 4, 2023
Closed
Closed
@saimn saimn deleted the docs-python3.11 branch October 4, 2023 20:52
pllim added a commit to pllim/astropy that referenced this pull request Oct 5, 2023
@pllim
Reverts astropy#15433 to temporary pin Python doc
7c12186 
in intersphinx because they removed a ref label but then readded it.
@pllim pllim mentioned this pull request Oct 5, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Docs no-changelog-entry-needed

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@saimn @pllim