Test (again) docs build with sphinx-automodapi fork that fixes the inheritance-diagram links#15104
Closed
ayshih wants to merge 2 commits intoastropy:mainfrom
Closed
Test (again) docs build with sphinx-automodapi fork that fixes the inheritance-diagram links#15104ayshih wants to merge 2 commits intoastropy:mainfrom
ayshih wants to merge 2 commits intoastropy:mainfrom
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
Contributor
Author
|
Apparently what I should have done for reopening the old PR was first reopen and then rebase, not first rebase and then reopen. Oh well, I've already created this new PR. |
Contributor
Author
|
Closing because it is no longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sphinx-doc/sphinx#10614 has now been merged. The remaining broken inheritance-diagram links needs a fix in sphinx-automodapi: astropy/sphinx-automodapi#172
Original post:
This is a test PR to confirm that the pending Sphinx PR sphinx-doc/sphinx#10614 to fix the bug with links in inheritance diagrams does in fact fix the issue in Astropy's docs (#4935). Do not merge this PR.
There's renewed activity on the Sphinx PR, but my previous test PR (#13357) apparently can't be re-opened.