Skip to content

Test docs build with Sphinx fork that fixes the inheritance-diagram links#13357

Closed
ayshih wants to merge 1 commit intoastropy:mainfrom
ayshih:sphinx_bug
Closed

Test docs build with Sphinx fork that fixes the inheritance-diagram links#13357
ayshih wants to merge 1 commit intoastropy:mainfrom
ayshih:sphinx_bug

Conversation

@ayshih
Copy link
Contributor

@ayshih ayshih commented Jun 20, 2022

This is a test PR to confirm that the pending Sphinx PR (sphinx-doc/sphinx#10576) to fix the bug with links in inheritance diagrams does in fact fix the issue in Astropy's docs (#4935). Do not merge this PR.

Edit: The relevant Sphinx PR is now sphinx-doc/sphinx#10614

@github-actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@ayshih
Copy link
Contributor Author

ayshih commented Jun 20, 2022

Confirmed: the inheritance-diagram links do get fixed

@pllim pllim added this to the v5.2 milestone Jun 20, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Nov 17, 2022
@pllim
Copy link
Member

pllim commented Nov 17, 2022

@ayshih et al., is this just waiting for us to unpin Sphinx?

@ayshih
Copy link
Contributor Author

ayshih commented Nov 17, 2022

Unfortunately, no. The Sphinx PR (sphinx-doc/sphinx#10614) hasn't yet been merged, so the fixes aren't in any release.

@pllim pllim removed the Close? Tell stale bot that this issue/PR is stale label Nov 17, 2022
@astrofrog astrofrog modified the milestones: v5.2, v5.2.1 Dec 13, 2022
@saimn saimn modified the milestones: v5.2.1, v5.2.2 Jan 6, 2023
@github-actions github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Apr 17, 2023
@github-actions
Copy link
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@saimn saimn modified the milestones: v5.2.2, v5.2.3 Apr 19, 2023
@pllim
Copy link
Member

pllim commented Apr 24, 2023

Looks like upstream sphinx-doc/sphinx#10614 is still unmerged. 😿

@github-actions github-actions bot added the closed-by-bot Closed by stale bot label May 18, 2023
@github-actions
Copy link
Contributor

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Close? Tell stale bot that this issue/PR is stale closed-by-bot Closed by stale bot Docs no-changelog-entry-needed Upstream Action Required Was: Upstream Fix Required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants