fix w0wz de_density_scale#14991
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
pllim
left a comment
There was a problem hiding this comment.
LGTM at a glance but someone who actually use cosmology stuff should approve. Thanks!
|
devdeps failures appear unrelated. I restarted the other jobs. 🤞 |
|
@RyanCamo , if you are okay with this fix, please approve. Thanks! |
pllim
left a comment
There was a problem hiding this comment.
aconley approved so I am approving by proxy. Thanks, everyone!
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
@nstarman , any chance you can manually backport this to v5.0.x or is that not applicable? |
…991-on-v5.3.x Backport PR #14991 on branch v5.3.x (fix w0wz de_density_scale)
|
Too much refactoring, making backport to v5.0.x too confusing for me. But this bug is so subtle that I think we should still try to fix up v5.0.x. @nstarman , please do a manual patch to v5.0.x. Thanks! 🙏 |
|
Will do. I have a dev branch for this, but the tests are quite different. |
(cherry picked from commit 7c30252) Signed-off-by: nstarman <nstarman@users.noreply.github.com> # Conflicts: # astropy/cosmology/flrw/tests/test_w0wzcdm.py # astropy/cosmology/flrw/w0wzcdm.py # astropy/cosmology/tests/test_core.py # astropy/cosmology/tests/test_utils.py
(cherry picked from commit 7c30252) Signed-off-by: nstarman <nstarman@users.noreply.github.com> # Conflicts: # astropy/cosmology/flrw/tests/test_w0wzcdm.py # astropy/cosmology/flrw/w0wzcdm.py # astropy/cosmology/tests/test_core.py # astropy/cosmology/tests/test_utils.py
(cherry picked from commit 7c30252) Signed-off-by: nstarman <nstarman@users.noreply.github.com> # Conflicts: # astropy/cosmology/flrw/tests/test_w0wzcdm.py # astropy/cosmology/flrw/w0wzcdm.py # astropy/cosmology/tests/test_core.py # astropy/cosmology/tests/test_utils.py
(cherry picked from commit 7c30252) Signed-off-by: nstarman <nstarman@users.noreply.github.com> # Conflicts: # astropy/cosmology/flrw/tests/test_w0wzcdm.py # astropy/cosmology/flrw/w0wzcdm.py # astropy/cosmology/tests/test_core.py # astropy/cosmology/tests/test_utils.py
Backport PR #14991 on branch v5.0.x (fix w0wz de_density_scale)
EDIT: Fix #14975
TODO: