-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Update WCSAxes to pass multiple positional arguments to Axes
#13880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks to have worked as the dev version test is now passing. (This fix also works for sunpy: sunpy/sunpy#6500) |
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like it is fully backwards compatible too, nice! In that case, no need for change log.
I'll keep this open so wcsaxes maintainers can have chance to take a look.
astrofrog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
…al arguments to `Axes`
…al arguments to `Axes`
…880-on-v5.1.x Backport PR #13880 on branch v5.1.x (Update `WCSAxes` to pass multiple positional arguments to `Axes`)
…880-on-v5.0.x Backport PR #13880 on branch v5.0.x (Update `WCSAxes` to pass multiple positional arguments to `Axes`)
Description
This pull request is to address a change in the Matplotlib
Axes.__init__signature. The change in this PR should be backwards compatible with older Matplotlib versions, however, it will break code which initialisesWCSAxeswith positional arguments forwcsetc. If that's an issue, it should be possible to "clean"*argsbefore passing it toAxes.Fixes #13873
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel. Codestyle issues can be fixed by the bot.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.