Conversation
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
I found the changes elsewhere all pretty clear improvements, so would be happy to add this. |
|
I'll rebase this PR when all the other ones are in. Hopefully it will pass / require very little further work. |
|
Do we want to exclude some directories from |
Yes, definitely a good idea. Also, I'll ignore all the files in units and coordinates that are generated by |
665a9b0 to
c48cb73
Compare
8cb4005 to
c62f306
Compare
|
I need to rebase to capture the timeseries related merge, but GTG otherwise |
c62f306 to
9caaf11
Compare
|
Rebased and ready for review. |
pllim
left a comment
There was a problem hiding this comment.
I don't grok the pre-commit stuff so maybe @WilliamJamieson can look at that one. But the other changes LGTM. Thanks!
WilliamJamieson
left a comment
There was a problem hiding this comment.
The pre-commit looks fine to me, not sure about the rest of the changes.
|
Thanks! |
Pyupgrade upgrades syntax for newer versions of the language. Some features, like f-strings, are faster. Other features improve code style. All upgrades ensure code contributions meet the best practices of our minimum python version.
Also, when we bump a python version we can run
pre-commit run —all-filesto upgrade all existing code.I also cleaned up the YAML with a YAML cleaner.
Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.