Skip to content

run pyupgrade on coordinates#13379

Merged
mhvk merged 1 commit intoastropy:mainfrom
nstarman:run-pyupgrade-coordinates
Jun 23, 2022
Merged

run pyupgrade on coordinates#13379
mhvk merged 1 commit intoastropy:mainfrom
nstarman:run-pyupgrade-coordinates

Conversation

@nstarman
Copy link
Copy Markdown
Member

@nstarman nstarman commented Jun 23, 2022 •
edited by mhvk
Loading

I ran pyupgrade —py38-plus on astropy/coordinates.

  • a few style corrections

Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@nstarman
run pyupgrade
72165b0 
+ a few style corrections

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman added this to the v5.2 milestone Jun 23, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 23, 2022

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman requested a review from mhvk June 23, 2022 19:35
@nstarman nstarman marked this pull request as ready for review June 23, 2022 19:35
mhvk
mhvk approved these changes Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these are clear improvements, so nice!

@mhvk mhvk merged commit c0a6d03 into astropy:main Jun 23, 2022
@nstarman nstarman deleted the run-pyupgrade-coordinates branch June 23, 2022 20:28
@nstarman
Copy link
Copy Markdown
Member Author

nstarman commented Jun 24, 2022

pyupgrade can't recurse through a directory, so I hacked around it with unix commands. There is good recursion when used in pre-commit, which I just ran. I'm finding a bunch more corrections. I'll push another PR.

@nstarman nstarman mentioned this pull request Jul 1, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes

Assignees

No one assigned

Labels

coordinates no-changelog-entry-needed

Projects

None yet

Milestone

v5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@nstarman @mhvk