Skip to content

DOC: Hackfix RTD#12988

Merged
pllim merged 1 commit intoastropy:mainfrom
pllim:hotfix-rtd
Mar 24, 2022
Merged

DOC: Hackfix RTD#12988
pllim merged 1 commit intoastropy:mainfrom
pllim:hotfix-rtd

Conversation

@pllim
Copy link
Member

@pllim pllim commented Mar 24, 2022

Description

This pull request is to get RTD to build again ASAP.

Fixes #12986

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Member Author

pllim commented Mar 24, 2022

Green this time... let's get this in. 🤞

https://readthedocs.org/projects/astropy/builds/16459280/

@pllim pllim marked this pull request as ready for review March 24, 2022 18:38
@pllim
Copy link
Member Author

pllim commented Mar 24, 2022

CI isn't necessary here and GitHub Actions is flaky right now anyway.

@pllim pllim merged commit f6569ce into astropy:main Mar 24, 2022
@pllim pllim deleted the hotfix-rtd branch March 24, 2022 18:39
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 24, 2022
pllim added a commit that referenced this pull request Mar 24, 2022
…988-on-v5.0.x

Backport PR #12988 on branch v5.0.x (DOC: Hackfix RTD)
@WilliamJamieson
Copy link
Contributor

Note this is related to this issue: sphinx-doc/sphinx#10291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTD is broken

2 participants