Skip to content

Require pytest 7.0 or later for installation#12914

Merged
pllim merged 1 commit intoastropy:mainfrom
eerovaher:min-pytest
Mar 4, 2022
Merged

Require pytest 7.0 or later for installation#12914
pllim merged 1 commit intoastropy:mainfrom
eerovaher:min-pytest

Conversation

@eerovaher
Copy link
Copy Markdown
Member

@eerovaher eerovaher commented Mar 3, 2022

Description

Using older versions of pytest is not possible since #12823 (backported in #12849). But while setting minversion = 7.0 in the [tool:pytest] section of setup.cfg does prevent older versions of pytest from attempting to run the tests, it alone does not prevent pip from being happy with an older version. Additionally, pytest-doctestplus was made compatible with pytest 7.0 in scientific-python/pytest-doctestplus#171, so its minimum required version has to be updated too.

See also astropy/pytest-astropy#49

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Using older versions of `pytest` is not possible since
astropy#12823. Furthermore, `pytest-doctestplus` was made
compatible with `pytest` 7.0 in scientific-python/pytest-doctestplus#171, so its
minimum required version has to be updated too.
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pllim pllim merged commit c53ed14 into astropy:main Mar 4, 2022
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 4, 2022
pllim added a commit that referenced this pull request Mar 4, 2022
…914-on-v5.0.x

Backport PR #12914 on branch v5.0.x (Require `pytest` 7.0 or later for installation)
@eerovaher eerovaher deleted the min-pytest branch March 17, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants