Require pytest 7.0 or later for installation#12914
Merged
pllim merged 1 commit intoastropy:mainfrom Mar 4, 2022
Merged
Conversation
Using older versions of `pytest` is not possible since astropy#12823. Furthermore, `pytest-doctestplus` was made compatible with `pytest` 7.0 in scientific-python/pytest-doctestplus#171, so its minimum required version has to be updated too.
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Mar 4, 2022
pllim
added a commit
that referenced
this pull request
Mar 4, 2022
…914-on-v5.0.x Backport PR #12914 on branch v5.0.x (Require `pytest` 7.0 or later for installation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using older versions of
pytestis not possible since #12823 (backported in #12849). But while settingminversion = 7.0in the[tool:pytest]section ofsetup.cfgdoes prevent older versions ofpytestfrom attempting to run the tests, it alone does not preventpipfrom being happy with an older version. Additionally,pytest-doctestpluswas made compatible withpytest7.0 in scientific-python/pytest-doctestplus#171, so its minimum required version has to be updated too.See also astropy/pytest-astropy#49
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.