Merged
Conversation
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
9 tasks
nden
approved these changes
Oct 8, 2021
Member
|
Thanks @WilliamJamieson for the fix and @nden for the quick review. |
Member
|
For future reference, which other PR is this following up on? That is, which PR first broke it? |
Member
|
I think #12232 motivated this PR. |
Contributor
|
RTD is also failing on the 4.3 branch with those warnings. @meeseeksdev backport to v4.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Oct 14, 2021
saimn
added a commit
that referenced
this pull request
Oct 14, 2021
…235-on-v4.3.x Backport PR #12235 on branch v4.3.x (Fix for doctest failure)
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the docs build test is failing for most of the new astropy pull requests. This PR attempts to resolve the issues preventing the docs from building.
The issue preventing the docs build test from passing appears to be the way the
codeguide.rstfile was trying to link to the python docssuper()documentation. This is probably due to some small changes in the python docs with the python 3.10 release.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.