BUG: Fix imperials import from astropy.units#11977
Merged
Merged
Conversation
eteq
approved these changes
Jul 27, 2021
eteq
left a comment
Member
There was a problem hiding this comment.
FWIW, I also double-checked this test fails without the fix, so this LGTM modulo my small clarification suggestion.
adrn
approved these changes
Jul 27, 2021
Member
|
Good catch @pllim ! LGTM |
Co-authored-by: Erik Tollerud <erik.tollerud@gmail.com>
Member
Author
|
Cron jobs from first commit still running. I'll leave it to your good judgement on when you want to merge this. Thanks for the reviews! |
Member
eteq
added a commit
that referenced
this pull request
Jul 27, 2021
BUG: Fix imperials import from astropy.units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to re-enable old usage of
imperialswithinastropy.unitsnamespace.Fixes #11975 . This is a follow-up of #11204 and #11592 . cc @namurphy
I will also enable cron jobs, just in case...
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.