When writing a table, make only a shallow copy#11919
Merged
taldcroft merged 3 commits intoastropy:mainfrom Jul 6, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Member
|
I'm pretty sure the test fail will go away after rebasing on main after #11921. This looks fine otherwise. |
Member
|
I think a changelog entry is warranted, both to highlight a performance improvement and in the very unlikely event that this causes something unexpected in a custom writer. |
3f49fae to
645c1f3
Compare
Contributor
Author
|
OK, thanks! I added a changelog entry and rebased; good to check that everything passes! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into the errors that occur when writing a table without first making a copy. It is clear the problem is that the writer can set
infoproperties such asformat- obviously, these should not propagate back to the input table. A copy avoids this, but it is not necessary for this to be a deep copy.Fixes #7605
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.