Bugfix for `fix_inputs` bounding box by WilliamJamieson · Pull Request #11908 · astropy/astropy

WilliamJamieson · 2021-06-30T18:43:42Z

Description

During some other work on ~astropy.modeling related to bounding boxes I noticed that the fix_inputs routine for handling reducing the bounding box, including the test of that routine were flawed when handling multiple inputs.

Multi-input bounding boxes are tuples of tuples (e.g. ((-1, 1), (-2, 2))); however, they are ordered in the "python" or "C" ordering meaning that they are reversed to how one would normally expect to read them. That is if a model has inputs (x, y), then the bounding box would be ((y_min, y_max), (x_min, x_max)) (in the example above (-1, 1) is the bounding box for the y, index 1 input). One can see that this is the case by noticing the bounding box reversal here in ~astropy.modeling.core.

Both fix_inputs and the bounding_box test for fix_inputs assume that the ordering of the bounding boxes in the bounding box tuple matches the order of inputs; however, this is an incorrect assumption in light of the above note. I have fixed this by performing the fix_inputs removal of bounding_box entries on the reversed bounding box and then reversing it again.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will
review this pull request of some common things to look for. This list
is not exhaustive.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label.
Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
If the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

WilliamJamieson · 2021-06-30T18:44:25Z

Tagging @nden and @perrygreenfield.

github-actions · 2021-06-30T18:44:27Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

…ding_box Bugfix for `fix_inputs` bounding box

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

…ding_box Bugfix for `fix_inputs` bounding box

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage.

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring

Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Added initial new bounding box Most changes to integrate new bounding box Fixed broken tests Updated bounding_box and its unit tests to include equality Added pseudo support for model set bounding boxes Updated bounding_box to be better able to accept auto-generated bounding_box Integrated new bounding_box into automatic bounding_boxes Fixed final broken test. Removed an accidental print. Fixed asdf bug. Refactored order handling for bounding_box Removed references to the old _BoundingBox. Finished TODO to remove check on bounding box input processing. Moved more i/o handling for bounding box into bounding box class Switched RuntimeError to RuntimeWarning for interval bounds validation. Fixed warning to be warning not exception Added documentation Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Fixed doctest failure Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Moved changelog to correct folder. Addressed perrygreenfield's comments. Removed all references to `nan_index`. Changed `_model` to `model` in BoundingBox Added bounding_box to API reference. Updated docstrings for read-the-docs. Fixed more docstrings More docstring fixes New attempt at fixing docstring Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Refactored and added tests to increase test coverage. Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added changelog entry. Added `__all__` to bounding_box.py Fixed more docstrings Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Added `__all__` to bounding_box.py Fixed more docstrings Refactored generic_call Removed generic_call from core.py Refactored _generic_evaluate into Model class Moved get_bounding_box into model class Moved _prepare_inputs_* functions into model class Refactored _prepare_outputs_* into model. Refactored validate_input_shapes into model Refactored some helper functions into model. Fixed codestyle errors. Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Moved changelog to correct folder Fixed rebase issue Most changes to integrate new bounding box Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Updated _fix_input_bounding_box to be in line with PR astropy#11908. Made fix_inputs_with_bounding_box more robust Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed more docstrings Added changelog entry. Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Integrated new bounding_box into automatic bounding_boxes Finished TODO to remove check on bounding box input processing. Improved test_custom_model_bounding_box test to test with_bounding_box=True Removed debugging print from a test. Fixed unknown error in asdf round-trip for bounding_box Added `__all__` to bounding_box.py Fixed more docstrings Minor refactoring and additional documentation. More documentation added. Fixed get_bounding_box in asdf Fixed rebase issue Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Moved changelog to correct folder Added changelog entry. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Minor refactoring and additional documentation. More documentation added. Introduced ignored bounding box inputs Added slice argument handling for compound bounding box Cleaned up rebase Factored evaluation methods out of bounding box Finished documenting BoundingDomain class. Added in basic compound bounding box class Integrated compound bounding box partially into core.py Finished integrating CompoundBoundingBox with core.py Finished adding tests for compound bounding box Added documentation for CompoundBoundingBox Cleaned up SliceArgument a bit Removed `add_ignored_axes` and related methods as these are no longer required. Added order notes to CompoundBoundingBox Added changelog entry. Updated model evaluation to be simpler Updated `__all__` in bounding_box.py Fixed a misspelling Moved changelog to correct place. Removed bad file. Updated docstrings Fixed more docstring errors. Removed bad file from docs. Fixed docstring serialize compound bounding box fix flake8 Mostly working fix_inputs Fixed broken fix_inputs cases Changed `slice_arg` to `selector_arg` and related throughout compound bounding box Addressed some of perrygreenfield's review comments. Fix for Azure test failure Updated asdf to used `selector` and `slice`. Intermediate work to diagnose issue Removed all the debugging statements. Increased test coverage. Fixed copy for models with a compound bounding box Fix for normal models Further fix for other mixed scalar-array cases. Changed bounding box tests to reflect changes to fix mixed scalar-array bug. Fixed copy bug with compound models

github-actions Bot added the modeling label Jun 30, 2021

WilliamJamieson added 2 commits July 8, 2021 12:26

Added bugfix for fix inputs bounding box

25538dc

Added changelog entry

c8fe9b4

WilliamJamieson force-pushed the bugfix/fix_inputs_bounding_box branch from 1118c49 to c8fe9b4 Compare July 8, 2021 16:26

WilliamJamieson marked this pull request as ready for review July 8, 2021 16:26

WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this pull request Jul 8, 2021

Updated _fix_input_bounding_box to be in line with PR astropy#11908.

ea36f3b

WilliamJamieson mentioned this pull request Jul 8, 2021

bounding_box refactor #11930

Merged

9 tasks

nden added this to the v4.0.6 milestone Jul 10, 2021

nden added the backport-v4.0.x label Jul 10, 2021

nden approved these changes Jul 10, 2021

View reviewed changes

nden merged commit 297c8e6 into astropy:main Jul 13, 2021

WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this pull request Jul 21, 2021

Updated _fix_input_bounding_box to be in line with PR astropy#11908.

67e8874

eteq pushed a commit that referenced this pull request Jul 27, 2021

Merge pull request #11908 from WilliamJamieson/bugfix/fix_inputs_boun…

bf9ee50

…ding_box Bugfix for `fix_inputs` bounding box

WilliamJamieson deleted the bugfix/fix_inputs_bounding_box branch August 4, 2021 18:07

astrofrog pushed a commit that referenced this pull request Aug 16, 2021

Merge pull request #11908 from WilliamJamieson/bugfix/fix_inputs_boun…

3e0d10d

…ding_box Bugfix for `fix_inputs` bounding box

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bugfix for `fix_inputs` bounding box#11908

Bugfix for `fix_inputs` bounding box#11908
nden merged 2 commits into
astropy:mainfrom
WilliamJamieson:bugfix/fix_inputs_bounding_box

WilliamJamieson commented Jun 30, 2021 •

edited by nden

Loading

Uh oh!

WilliamJamieson commented Jun 30, 2021

Uh oh!

github-actions Bot commented Jun 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

WilliamJamieson commented Jun 30, 2021 • edited by nden Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist for package maintainer(s)

Uh oh!

WilliamJamieson commented Jun 30, 2021

Uh oh!

github-actions Bot commented Jun 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WilliamJamieson commented Jun 30, 2021 •

edited by nden

Loading