Change equality to allclose to fix test on 32 bit#11881
Merged
Conversation
Member
|
Alas, there is a failure still. |
fead444 to
fd71776
Compare
Contributor
Author
|
Ah, yes, comparing with 0 with atol=0 is not going to help, unless rtol is very large! Hopefully fixed now... |
nstarman
approved these changes
Jun 23, 2021
nstarman
left a comment
Member
There was a problem hiding this comment.
I see from the error messages that the offending differences were of order 1e-16, but consistently at the same index. It must be some special r2...
pllim
approved these changes
Jun 23, 2021
pllim
left a comment
Member
There was a problem hiding this comment.
Seems uncontroversial enough. Thanks!
p.s. I didn't even know assert_representation_allclose existed. TIL!
Member
|
p.p.s. Oh gawd... look like the backport bot takes the branch name from description, not the label name. @meeseeksdev backport to v4.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Jun 23, 2021
mhvk
added a commit
that referenced
this pull request
Jun 23, 2021
…881-on-v4.3.x Backport PR #11881 on branch v4.3.x (Change equality to allclose to fix test on 32 bit)
astrofrog
pushed a commit
that referenced
this pull request
Aug 17, 2021
Change equality to allclose to fix test on 32 bit
Member
|
This is needed in LTS so changing the milestone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw this failing test on https://github.com/astropy/astropy/pull/11879/checks?check_run_id=2889899758
It seems to be a problem in 4.3 as well - see https://github.com/astropy/astropy/runs/2887279374
Fix #11878