Skip to content

TST: Skip bayesian_info_criterion_lsq doctest#10925

Merged
pllim merged 1 commit intoastropy:masterfrom
pllim:skip-doctest-bayesian_info_criterion_lsq
Oct 22, 2020
Merged

TST: Skip bayesian_info_criterion_lsq doctest#10925
pllim merged 1 commit intoastropy:masterfrom
pllim:skip-doctest-bayesian_info_criterion_lsq

Conversation

@pllim
Copy link
Member

@pllim pllim commented Oct 22, 2020

to avoid failure due to slightly different result in
arm64 and big-endian s390x CI jobs.

Description

This pull request is an alternative to #10923

Fix #9657
Close #10923

to avoid failure due to slightly different result in
arm64 and big-endian s390x CI jobs.
@bsipocz
Copy link
Member

bsipocz commented Oct 22, 2020

I would prefer this workaround than the other one. Ideally, we would just stip the exotic archs that it runs into issues, but afaik that is not possible.

@pllim
Copy link
Member Author

pllim commented Oct 22, 2020

Technically, we could skip certain arch but the doc would look real ugly.

@bsipocz
Copy link
Member

bsipocz commented Oct 22, 2020

Yeah, keep it as is then. Checking on the numerical accuracy is also done in the tests, so no need to make it ugly for the docs.

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better like this! Thanks!

@pllim pllim merged commit ca96771 into astropy:master Oct 22, 2020
@pllim pllim deleted the skip-doctest-bayesian_info_criterion_lsq branch October 22, 2020 20:28
@pllim
Copy link
Member Author

pllim commented Oct 22, 2020

Thanks for the reviews!

bsipocz pushed a commit that referenced this pull request Nov 6, 2020
…rion_lsq

TST: Skip bayesian_info_criterion_lsq doctest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.2.3] bayesian_info_criterion_lsq failure with ARM64

3 participants