Skip to content

TST: Ignore unknown config ini key (pytest 6.1)#10730

Merged
dhomeier merged 2 commits intoastropy:masterfrom
pllim:pytest-no-qt-warn
Sep 27, 2020
Merged

TST: Ignore unknown config ini key (pytest 6.1)#10730
dhomeier merged 2 commits intoastropy:masterfrom
pllim:pytest-no-qt-warn

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Sep 14, 2020 •
edited
Loading

Description

This pull request is to utilize pytest-dev/pytest#7700 to silence this warning below that does not break tests but is kinda annoying. It will not be proven work (or not) until pytest 6.1 is out (pytest-dev/pytest#7703), so there is no point in merging this too soon.

=============================== warnings summary ===============================
.../_pytest/config/__init__.py:1148
  .../_pytest/config/__init__.py:1148: PytestConfigWarning: Unknown config ini key: qt_no_exception_capture
  
    self._warn_or_fail_if_strict("Unknown config ini key: {}\n".format(key))

-- Docs: https://docs.pytest.org/en/stable/warnings.html

We need to keep the unused plugin config due to #7572

@pllim pllim added this to the v4.2 milestone Sep 14, 2020
dhomeier
dhomeier reviewed Sep 27, 2020
View reviewed changes
@dhomeier dhomeier mentioned this pull request Sep 27, 2020
Closed
@saimn saimn marked this pull request as ready for review September 27, 2020 19:59
dhomeier
dhomeier approved these changes Sep 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it to the actual tests now; so once they've all succeeded this can go in, unless you want to still change the milestone.

@saimn saimn modified the milestones: v4.2, v4.0.2 Sep 27, 2020
@saimn
Copy link
Copy Markdown
Contributor

saimn commented Sep 27, 2020

Yes, this would need to be backported to the other release branches.
@dhomeier - I ran the tests and did not see the imp warning, so I think this is ready to merge once all builds pass.

@pllim pllim added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Sep 27, 2020
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Sep 27, 2020

Thanks, y'all!

@dhomeier
Copy link
Copy Markdown
Contributor

dhomeier commented Sep 27, 2020

Thanks for spotting this early on and having a solution ready before the problem popped up!

@dhomeier dhomeier merged commit aa8f4e1 into astropy:master Sep 27, 2020
@pllim pllim deleted the pytest-no-qt-warn branch September 28, 2020 13:59
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Sep 28, 2020

Kudos go to @nicoddemus and other pytest devs involved too to allow us to ignore this warning. 😄

astrofrog pushed a commit that referenced this pull request Oct 6, 2020
@dhomeier @astrofrog
Merge pull request #10730 from pllim/pytest-no-qt-warn
cd1eda2 
TST: Ignore unknown config ini key (pytest 6.1)
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
@dhomeier @astrofrog
Merge pull request #10730 from pllim/pytest-no-qt-warn
f33c71f 
TST: Ignore unknown config ini key (pytest 6.1)
eteq pushed a commit to eteq/astropy that referenced this pull request Oct 12, 2020
@dhomeier @eteq
Merge pull request astropy#10730 from pllim/pytest-no-qt-warn
af269bb 
TST: Ignore unknown config ini key (pytest 6.1)
eteq pushed a commit that referenced this pull request Oct 13, 2020
@dhomeier @eteq
Merge pull request #10730 from pllim/pytest-no-qt-warn
2cd233c 
TST: Ignore unknown config ini key (pytest 6.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn left review comments

@dhomeier dhomeier dhomeier approved these changes

Assignees

No one assigned

Labels

no-changelog-entry-needed testing zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now.

Projects

None yet

Milestone

v4.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @saimn @dhomeier