Fixed a check of non-equality between frames in a test#10300
Merged
mhvk merged 1 commit intoastropy:masterfrom May 4, 2020
Merged
Fixed a check of non-equality between frames in a test#10300mhvk merged 1 commit intoastropy:masterfrom
mhvk merged 1 commit intoastropy:masterfrom
Conversation
Member
|
This test diff implies API change that is not backward compatible. I'll let the people involved with the original PR to review this. Thanks! |
mhvk
approved these changes
May 4, 2020
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Thanks, this looks good! I think the initial test was really not quite right, so fine to just merge this as affects_dev (which I'll do)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10297
The test had a
!=, which now raises an error after #10154. It has been replaced withnot ... ._is_equivalent_frame(), which works after #10290.