Fixed a bug with frame attributes that are coordinates when checking for frame equivalency#10290
Merged
mhvk merged 1 commit intoastropy:masterfrom May 4, 2020
Merged
Conversation
8676062 to
4a36e64
Compare
4a36e64 to
079d854
Compare
…for frame equivalency
079d854 to
4ed6520
Compare
Member
|
Milestoned for 4.1 as this fixes a problem in SunPy introduced by #10154. |
This was referenced May 4, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10287
BaseCoordinateFrame's version ofis_equivalent_frame()already had a private function for special handling of representation attributes (which is possibly removable in light of Implement __eq__ and __ne__ for coordinate classes #10154, but I did not touch that), so I added special handling for coordinate attributes. Now, if the coordinate attributes do not have equivalent frames, it avoids checking for equality (which would raise an error).SkyCoord's version ofis_equivalent_frame()to call the private function underBaseCoordinateFrame.