Fix hard-to-debug import issues.#10282
Conversation
taldcroft
left a comment
There was a problem hiding this comment.
Looks good. I'm seeing the same 32bit-and-parallel fail in my completely-unrelated What's New PR #10279. I guess @pllim was mentioning this and it sounds familiar as a known issue. Anyway, when astropy requires Python 3.7 then we will have custom module attributes and all this will just go away! I think a lot of other stuff will clean up too.
|
Merge only when also CI 32 bit passes! |
|
Good, that got rid of two problems! Now if only I hadn't caused them in the first place... |
|
@taldcroft - out of curiosity, how will the custom attributes help? Maybe open an issue about it so we know to do it? |
|
In Python 3.7 you can have a module-level |
|
I think we will support only Python 3.7+ for the first astropy release that is supported beyond 2021-12-23, which is the Python 3.6 end of support. So that is probably the Fall 2021 release. |
|
Ah, yes, I had see that - but had not realized it could (or at least should) work for things like this. |
|
I think the switch is earlier than end of 2021, at least there was some vague agreement to follow NEP29 which drops 3.6 this summer (so we can practically start cleaning up the code in the middle of the summer in prep for 4.2). |
Fixes the very annoying import of all of coordinates when just wanting to load
io.ascii, which in turn led toTimebeing updated, etc.Thanks @taldcroft for figuring this out (and again apologies for causing the issue in the first place).