fix: batch of small bug fixes (#1837, #1908, #1991, #1800, #1977)#2024
Merged
fix: batch of small bug fixes (#1837, #1908, #1991, #1800, #1977)#2024
Conversation
The help text for --wait on `astro dev start` and `astro dev restart` stated "The default is 5 minutes" but the actual defaultWaitTime is 1 minute. Remove the hardcoded text since Cobra already appends the default value automatically. Closes #1837 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
#1991) In Airflow 3, the secret_key config moved from [webserver] to [api]. Update the AF3 docker-compose template to use AIRFLOW__API__SECRET_KEY and remove AIRFLOW__WEBSERVER__RBAC and AIRFLOW__WEBSERVER__EXPOSE_CONFIG which are no longer applicable in Airflow 3. Closes #1991 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When docker-compose.override.yml contains invalid YAML, the compose loader may return a nil project without an error. Add a nil check before accessing project fields to prevent a nil pointer dereference panic. Closes #1800 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The upgrade notification hardcoded `brew upgrade astro` for macOS users, but Homebrew core lags ~1 week behind GitHub releases, leading to confusing "formula not available" errors. Use the same docs link for all platforms instead. Closes #1977 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeremybeard
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch of 5 small, verified bug fixes from open issues:
--waitflag help text claimed default is 5 minutes, but actual default is 1 minute. Removed the hardcoded text since Cobra already displays the default.astro dev initdoes not passruff checkfor Airflow 2.x #1908 — Airflow 2 example DAG used bareexcept:which failsruff check(E722). Changed toexcept Exception:to match the Airflow 3 version.AIRFLOW__WEBSERVER__SECRET_KEY. Replaced withAIRFLOW__API__SECRET_KEYand removedRBAC/EXPOSE_CONFIGvars that don't apply to AF3.docker-compose.override.ymlhas invalid YAML.brew upgrade astrofor macOS, but Homebrew lags ~1 week behind releases. Now points all platforms to the docs link.Test plan
go build ./...compiles cleanlyruff check airflow/include/airflow2/exampledag.pypassesastro dev start --helpno longer says "default is 5 minutes"AIRFLOW__API__SECRET_KEY🤖 Generated with Claude Code