Segfault when docker compose override is invalid #1800
Description
Describe the bug
CLI gets a segfault when running start, restart, or stop commands and there is a typo in docker-compose.override.yml. I figure it would be better if the cli verified the yaml and logged an error rather than segfaulting.
astro dev start
✔ Project image has been updated
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x1023dd548]
goroutine 1 [running]:
github.com/astronomer/astro-cli/airflow.init.func2({0x14000908090, 0xe}, {0x1400005a004, 0x25}, {0x1024c3b83?, 0x0?}, {0x0?, 0x0?}, {0x1024e9ffd?, 0x0?}, ...)
github.com/astronomer/astro-cli/airflow/docker.go:1367 +0x3a8
github.com/astronomer/astro-cli/airflow.(*DockerCompose).Start(0x140005c0000, {0x0?, 0x1024c3b83?}, {0x1024e9ffd, 0x15}, {0x0, 0x0}, {0x0?, 0x0?}, 0x0?, ...)
github.com/astronomer/astro-cli/airflow/docker.go:249 +0x3b4
github.com/astronomer/astro-cli/cmd.airflowStart(0x0?, {0x104a6c820?, 0x1400006bb88?, 0x0?}, {0x10322f5a0, 0x140006fddc0})
github.com/astronomer/astro-cli/cmd/airflow.go:695 +0x204
github.com/astronomer/astro-cli/cmd.newAirflowStartCmd.func1(0x140007fe608?, {0x104a6c820?, 0x0?, 0x0?})
github.com/astronomer/astro-cli/cmd/airflow.go:243 +0x28
github.com/spf13/cobra.(*Command).execute(0x140007fe608, {0x104a6c820, 0x0, 0x0})
github.com/spf13/cobra@v1.8.1/command.go:985 +0x834
github.com/spf13/cobra.(*Command).ExecuteC(0x140003fcf08)
github.com/spf13/cobra@v1.8.1/command.go:1117 +0x344
github.com/spf13/cobra.(*Command).Execute(0x1032071c0?)
github.com/spf13/cobra@v1.8.1/command.go:1041 +0x1c
main.main()
github.com/astronomer/astro-cli/main.go:21 +0x38
What CLI Version did you experience this bug?
1.33.0
This CLI bug is related to which Astronomer Platform?
- Astro
- Software
- None/Unknown
What Operating System is the above CLI installed on?
osx 15.1.1
🪜 Steps To Reproduce
Add a random character to the docker-compose file, like
version: "3.1"
services:
scheduler:
volumes:
- ../dat:/usr/local/airflow/dat:ro
d
📸 Screenshots