fix AF object handling with podman container engine#1759
Merged
neel-astro merged 4 commits intomainfrom Jan 29, 2025
Merged
Conversation
schnie
reviewed
Dec 20, 2024
|
|
||
| stringOut := string(out) | ||
| return stringOut | ||
| return stringOut, nil |
Member
There was a problem hiding this comment.
Noticed we're changing the function signature here and it got me wondering why this function didn't already return an error. Should we also return the error here on L32? - return errors.Wrapf(err, "error encountered executing airflow command") or something?
Contributor
Author
There was a problem hiding this comment.
Good catch, updated the PR
schnie
approved these changes
Jan 29, 2025
Member
schnie
left a comment
There was a problem hiding this comment.
Looks good, thanks @neel-astro!
BasPH
pushed a commit
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes:
docker, instead of picking the right container engine. This PR fixes that logic and adds error handling around it.🎟 Issue(s)
Related #1724
🧪 Functional Testing
Added/updated applicable unit tests
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft