Skip to content

Make SAMPIntegratedClient inherit from SAMPClient#41

Closed
astrofrog wants to merge 49 commits into
sampfrom
samp-integrated-inherit
Closed

Make SAMPIntegratedClient inherit from SAMPClient#41
astrofrog wants to merge 49 commits into
sampfrom
samp-integrated-inherit

Conversation

@astrofrog

Copy link
Copy Markdown
Owner

No description provided.

Luigi Paioro and others added 30 commits December 1, 2013 15:45
…op test added. Clients communication test added.
…r incoming registrations in case of missing Tkinter.
… of __init__, so the the garbage collector doesn't fails if the hub initialization raises an exception.
This was discussed and agreed on in GH astropy#972.
In addition to the structure suggested there by @lpaioro,
I put the constants and errors in separate files.
@astrofrog

Copy link
Copy Markdown
Owner Author

One issue with this approach is that it adds the following methods to the integrated client:

    def start(self):
    def stop(self, timeout=0.1):
    def register(self):
    def unregister(self):

but I'm not sure whether they should be available to the user.

@astrofrog astrofrog closed this Jun 14, 2014
astrofrog added a commit that referenced this pull request Nov 23, 2016
code for generating and comparing images
astrofrog pushed a commit that referenced this pull request Jul 4, 2017
Add void arguments also in erfaversion.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants