Make SAMPIntegratedClient inherit from SAMPClient#41
Closed
astrofrog wants to merge 49 commits into
Closed
Conversation
…pt added with `scripts`
…. Modified the print statement too.
…op test added. Clients communication test added.
…r incoming registrations in case of missing Tkinter.
…the doctest errors.
…nt with Python 3
… of __init__, so the the garbage collector doesn't fails if the hub initialization raises an exception.
This was discussed and agreed on in GH astropy#972. In addition to the structure suggested there by @lpaioro, I put the constants and errors in separate files.
cd astropy/vo/samp autopep8 -i --ignore E501,E126,E128,E225,E226,E231 -r . tests/
…methods with the same signature
9 tasks
Owner
Author
|
One issue with this approach is that it adds the following methods to the integrated client: but I'm not sure whether they should be available to the user. |
astrofrog
added a commit
that referenced
this pull request
Nov 23, 2016
code for generating and comparing images
astrofrog
pushed a commit
that referenced
this pull request
Jul 4, 2017
Add void arguments also in erfaversion.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.