Skip to content

Update DepositTx for monorepo #1410#42

Merged
ethanoroshiba merged 9 commits intomainfrom
eoroshiba/update_deposit
Sep 11, 2024
Merged

Update DepositTx for monorepo #1410#42
ethanoroshiba merged 9 commits intomainfrom
eoroshiba/update_deposit

Conversation

@ethanoroshiba
Copy link
Copy Markdown

astriaorg/astria#1410 changes the Deposit message in the sequencer_block API, necessitating changes to DepositTx in Geth

Copy link
Copy Markdown
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending submission of parent mono pro

github-merge-queue bot pushed a commit to astriaorg/astria that referenced this pull request Sep 11, 2024
…1410)

## Summary
Added `id_of_source_transaction` and `position_in_source_transaction` to
`Deposit`.

## Background
Previous deposit events had no information about the deposit source, so
rollups could not trace if their deposits had landed without checking
the balance. Additionally, this could result in deposit txs having the
same hash in the EVM.

## Changes
- Created primitive proto type `TransactionId` for identifying source
transaction in deposits.
- Added `id_of_source_transaction` and `position_in_source_transaction`
to `Deposit`.
- Included tx id in the ephemeral state via `current_source()` so that
it can be accessed by actions.
- Added accessors/mutators for deposit index to `StateReadExt` and
`StateWriteExt` traits in `transaction`.
- Updated `bridge_lock` and `ics20_transfer` actions to populate
`Deposit` events with transaction id and index based on the state.

## Testing
Added test to ensure `position_in_source_transaction` is incremented
correctly.

## Breaking Changelist
- App hash changed because of increasing block fees due to longer length
of `Deposit`.
- Changed SequencerBlock API `Deposit` event, having two new mandatory
fields `source_transaction_id` and `source_action_index`.
`source_transaction_id` uses a new primitive proto type `TransactionId`.

## Related Issues
with astriaorg/astria-geth#42, closes #1402

---------

Co-authored-by: Jordan Oroshiba <jordan@astria.org>
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: jesse snyder <jessetsnyder@gmail.com>
@ethanoroshiba ethanoroshiba marked this pull request as ready for review September 11, 2024 16:01
@ethanoroshiba ethanoroshiba merged commit 401c3d5 into main Sep 11, 2024
@ethanoroshiba ethanoroshiba deleted the eoroshiba/update_deposit branch September 11, 2024 16:11
github-merge-queue bot pushed a commit to astriaorg/astria that referenced this pull request Sep 11, 2024
## Summary
Update geth tag to `latest` for
astriaorg/astria-geth#42

## Background
#1410 required changes to `astria-geth`, which necessitated changing the
geth dev tag to be the specific PR number. Now that the geth PR is
merged, we can bump the tag.

## Changes
- Changed `evm-rollup` geth dev tag to `latest` and bumped chart
versions.
sgranfield4403-3 added a commit to sgranfield4403-3/astria that referenced this pull request Oct 2, 2025
…1410)

## Summary
Added `id_of_source_transaction` and `position_in_source_transaction` to
`Deposit`.

## Background
Previous deposit events had no information about the deposit source, so
rollups could not trace if their deposits had landed without checking
the balance. Additionally, this could result in deposit txs having the
same hash in the EVM.

## Changes
- Created primitive proto type `TransactionId` for identifying source
transaction in deposits.
- Added `id_of_source_transaction` and `position_in_source_transaction`
to `Deposit`.
- Included tx id in the ephemeral state via `current_source()` so that
it can be accessed by actions.
- Added accessors/mutators for deposit index to `StateReadExt` and
`StateWriteExt` traits in `transaction`.
- Updated `bridge_lock` and `ics20_transfer` actions to populate
`Deposit` events with transaction id and index based on the state.

## Testing
Added test to ensure `position_in_source_transaction` is incremented
correctly.

## Breaking Changelist
- App hash changed because of increasing block fees due to longer length
of `Deposit`.
- Changed SequencerBlock API `Deposit` event, having two new mandatory
fields `source_transaction_id` and `source_action_index`.
`source_transaction_id` uses a new primitive proto type `TransactionId`.

## Related Issues
with astriaorg/astria-geth#42, closes #1402

---------

Co-authored-by: Jordan Oroshiba <jordan@astria.org>
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: jesse snyder <jessetsnyder@gmail.com>
sgranfield4403-3 added a commit to sgranfield4403-3/astria that referenced this pull request Oct 2, 2025
## Summary
Update geth tag to `latest` for
astriaorg/astria-geth#42

## Background
#1410 required changes to `astria-geth`, which necessitated changing the
geth dev tag to be the specific PR number. Now that the geth PR is
merged, we can bump the tag.

## Changes
- Changed `evm-rollup` geth dev tag to `latest` and bumped chart
versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants