Skip to content

turn per-crate into workspace dependencies#38

Merged
SuperFluffy merged 2 commits intomainfrom
superfluffy/streamline-deps
May 24, 2023
Merged

turn per-crate into workspace dependencies#38
SuperFluffy merged 2 commits intomainfrom
superfluffy/streamline-deps

Conversation

@SuperFluffy
Copy link
Copy Markdown
Contributor

Crate dependencies are made into workspace dependencies if used in more than one crate.

@SuperFluffy SuperFluffy requested a review from steezeburger May 22, 2023 21:03
@SuperFluffy SuperFluffy temporarily deployed to BUF May 22, 2023 21:03 — with GitHub Actions Inactive
@SuperFluffy SuperFluffy requested a review from noot May 22, 2023 21:03
@SuperFluffy SuperFluffy temporarily deployed to BUF May 22, 2023 21:11 — with GitHub Actions Inactive
@SuperFluffy
Copy link
Copy Markdown
Contributor Author

Need to keep rand at 0.7 for now, because ed25519-dalek:1.0.1 still requires it. It's bumped to 0.8 in ed25519-dalek:rc.2, but a) is that not a full release, and b) that breaks libp2p-noise's snow dependency.

Once libp2p is updated to 0.52 we should be able to update rand 0.8.

Crate dependencies are made into workspace dependencies
if used in more than one crate.
@SuperFluffy SuperFluffy force-pushed the superfluffy/streamline-deps branch from 16e6073 to 7f3989f Compare May 24, 2023 10:51
@SuperFluffy SuperFluffy temporarily deployed to BUF May 24, 2023 10:51 — with GitHub Actions Inactive
@SuperFluffy SuperFluffy merged commit ba66dcd into main May 24, 2023
@SuperFluffy SuperFluffy deleted the superfluffy/streamline-deps branch May 24, 2023 13:53
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
## Summary
Changed execution API `rollup_id` to use primitive `RollupId` instead of
bytes.

## Background
`RollupId` is defined in primitives protobuf specs, but
`astria.execution.v1alpha2.GenesisInfo.rollup_id` was still using type
bytes instead of the primitive type.

## Changes
- Changed execution `rollup_id` to be of type `RollupId`.
- Regenerated Rust sources with protobuf compiler.
- Changed affected conductor functions to utilize `RollupId` instead of
bytes.
- Updated `evm-stack` and `evm-rollup` versions.

## Testing
With changes in `astria-geth`, passes smoke-test.

## Breaking Changelist
- Execution API changed, requires corresponding `astria-geth`
[changes](astriaorg/astria-geth#38) to function
properly.
- Will require followup PR to update geth `devTag` to `latest` once geth
PR is merged.

## Related Issues
With `astria-geth`
[#38](astriaorg/astria-geth#38), closes #1287

---------

Co-authored-by: Jordan Oroshiba <jordan@astria.org>
Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
## Summary
Update EVM-Rollup Geth `devTag` after #1291 and astria-geth
[#38](astriaorg/astria-geth#38).

## Background
#1291 relied on astria-geth PR
[#38](astriaorg/astria-geth#38) for `evm-rollup`
chart. Now that both PRs have been merged, the `devTag` can be updated
to `latest`.

## Changes
- Updated geth `devTag` to `latest` in `evm-rollup` `values.yaml`. 
- Updated `evm-rollup` and `evm-stack` versions.

## Testing
Passing e2e tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants