chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly#1510
Merged
ethanoroshiba merged 1 commit intomainfrom Sep 18, 2024
Merged
chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly#1510ethanoroshiba merged 1 commit intomainfrom
ethanoroshiba merged 1 commit intomainfrom
Conversation
noot
approved these changes
Sep 18, 2024
SuperFluffy
reviewed
Sep 19, 2024
| .wrap_err("failed to parse sequencer bridge address")?; | ||
|
|
||
| let sequencer_grpc_connection = | ||
| tonic::transport::Endpoint::new(sequencer_grpc_endpoint)?.connect_lazy(); |
Contributor
There was a problem hiding this comment.
Please provide an error context here.
steezeburger
added a commit
that referenced
this pull request
Sep 23, 2024
* main: feat(conductor): implement restart logic (#1463) fix: ignore `RUSTSEC-2024-0370` (#1483) fix, refactor(sequencer): refactor ics20 logic (#1495) fix(ci): use commit SHA instead of PR number preview-env images (#1501) chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly (#1510) fix(sequencer): Fix incorrect error message from BridgeUnlock actions (#1505) fix(bridge-contracts): fix memo transaction hash encoding (#1428) fix: build docker when workflow explicitly includes component (#1498) chore(sequencer): migrate from `anyhow::Result` to `eyre::Result` (#1387) fix(ci): typo for required field in sequencer preview-env (#1500) feat(ci): provide demo/preview environments (#1406)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed
sequencer_cometbft_clientandsequencer_grpc_clientconstruction so that each can be passed to consumers via cloning.Background
Both clients were previously constructed ad-hoc from endpoints, which was unnecessary.
Changes
sequencer_cometbft_clientandsequencer_grpc_clientup so that each can be passed to its consumers (StartupandSubmitter) via cloning.Testing
Passing all tests
Related Issues
closes #1315